Made virtualenv compatible with RHSCL/SCL #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivapoudel
pushed a commit
that referenced
this pull request
Jan 14, 2016
Made virtualenv compatible with RHSCL/SCL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
Upon trying to use this module in EL7 (CentOS) with the rh-python34 SC from softwarecollections.org, I found that the module was trying to call 'virtualenv' without the exec_prefix that is required when using Python from these sources.
I've implemented a similar fix to what was undertaken for pip, and as such this shouldn't break anything at all.
Cheers,
Chris